Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jaeger datastore #3149

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix: jaeger datastore #3149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
464c552
fix: jaeger datastore
mathnogueira Sep 12, 2023
c72f9bb
rollback jaeger version pin
mathnogueira Sep 12, 2023
58e6740
fix go version
mathnogueira Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/tracedb/jaegerdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func jaegerGrpcGetTraceByID(ctx context.Context, traceID string, conn *grpc.Clie
if !ok {
return traces.Trace{}, fmt.Errorf("jaeger stream recv: %w", err)
}
if st.Message() == "trace not found" {
if strings.Contains(st.Message(), "trace not found") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line owns me peace of mind! 🙃

return traces.Trace{}, connection.ErrTraceNotFound
}
return traces.Trace{}, fmt.Errorf("jaeger stream recv err: %w", err)
Expand Down
Loading