Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Updating and fixing the CLI cloud commands #3140

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(cli): Updating and fixing the CLI cloud commands #3140

merged 2 commits into from
Sep 11, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Sep 8, 2023

This PR improves the cloud commands with the initial feedback from the released version

Changes

  • Adds tracetest start agent command
  • Includes interactive loop after starting an agent
  • Fixes config not updating correctly
  • Fixes double selector after oauth login
  • Improves messaging and agent start

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/0fbe80afa6e7405d8265788e0b5c4292

@xoscar xoscar self-assigned this Sep 8, 2023
@xoscar xoscar marked this pull request as ready for review September 8, 2023 21:16
@xoscar xoscar merged commit 57a9ef2 into main Sep 11, 2023
38 checks passed
@xoscar xoscar deleted the fix/cli-cloud-cmds branch September 11, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@schoren schoren Awaiting requested review from schoren

@kdhamric kdhamric Awaiting requested review from kdhamric

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc