Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update pokeshop and kafka trigger docs #3129

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Sep 7, 2023

This PR updates Pokeshop API to show Kafka example and update WebUI docs to show Kafka trigger.

@danielbdias danielbdias changed the title wip - update pokeshop docs chore(docs): update pokeshop and kafka trigger docs Sep 7, 2023
@danielbdias danielbdias marked this pull request as ready for review September 7, 2023 22:04
Copy link
Contributor

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editing suggestions.

Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Good to merge once applied. 👌

Co-authored-by: Julianne Fermi <[email protected]>
Co-authored-by: Adnan Rahić <[email protected]>
@danielbdias danielbdias merged commit 44a1a34 into main Sep 8, 2023
31 checks passed
@danielbdias danielbdias deleted the update/docs-to-include-kafka branch September 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants