fix: oauth path building

kubeshop · Aug 28, 2024 · eb8121f · eb8121f
1 parent 1651afc
commit eb8121f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cli/config/config.go b/cli/config/config.go
@@ -43,8 +43,7 @@ type Config struct {
 }
 
 func (c Config) OAuthEndpoint() string {
-	return fmt.Sprintf("%s%s", c.URL(), c.Path())
-
+	return path.Join(c.URL(), c.Path())
 }
 
 func (c Config) URL() string {

diff --git a/cli/pkg/oauth/oauth.go b/cli/pkg/oauth/oauth.go
@@ -6,6 +6,7 @@ import (
 	"io"
 	"net"
 	"net/http"
+	"path"
 	"sync"
 
 	"github.com/kubeshop/tracetest/cli/ui"
@@ -58,7 +59,7 @@ func (s *OAuthServer) GetAuthJWT() error {
 		return fmt.Errorf("failed to start oauth server: %w", err)
 	}
 
-	loginUrl := fmt.Sprintf("%soauth?callback=%s", s.frontendEndpoint, url)
+	loginUrl := path.Join(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url))
 
 	ui := ui.DefaultUI
 	err = ui.OpenBrowser(loginUrl)