fix(backend): tempo cloud connection string (#3515)

* fix(backend): tempo cloud connection string * adding suggested change
kubeshop · Jan 11, 2024 · dc5f609 · dc5f609
1 parent bd6d3a1
commit dc5f609
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/server/tracedb/connection/port_linting.go b/server/tracedb/connection/port_linting.go
@@ -88,5 +88,15 @@ func parsePort(url string) string {
 		return ""
 	}
 
-	return regexGroups[1]
+	port := regexGroups[1]
+
+	if port == "1" {
+		if strings.Contains(url, "http") {
+			return "80"
+		} else {
+			return "443"
+		}
+	}
+
+	return port
 }
diff --git a/server/tracedb/datasource/http.go b/server/tracedb/datasource/http.go
@@ -27,6 +27,10 @@ type HttpClient struct {
 
 func NewHttpClient(name string, config *datastore.HttpClientConfig, callback HttpCallback) DataSource {
 	endpoint, _ := urlx.Parse(config.Url)
+	if endpoint.Port() == "443" {
+		endpoint.Scheme = "https"
+	}
+
 	client := &http.Client{
 		Transport: &http.Transport{
 			TLSClientConfig: getTlsConfig(config.TLS),

diff --git a/server/tracedb/tempodb.go b/server/tracedb/tempodb.go
@@ -23,7 +23,7 @@ import (
 )
 
 func tempoDefaultPorts() []string {
-	return []string{"9095", ""}
+	return []string{"9095", "443", "80", ""}
 }
 
 type tempoTraceDB struct {