test fix for out of order span requests

kubeshop · Nov 21, 2023 · a26aedd · a26aedd
1 parent 0a7cab1
commit a26aedd
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/agent/workers/poller/inmemory_datastore.go b/agent/workers/poller/inmemory_datastore.go
@@ -41,7 +41,14 @@ func (d *inmemoryDatastore) GetTraceByID(ctx context.Context, traceID string) (t
 		return traces.Trace{}, connection.ErrTraceNotFound
 	}
 
-	return traces.FromSpanList(spans), nil
+	trace := traces.FromSpanList(spans)
+
+	if !trace.RootSpan.ID.IsValid() {
+		// the trace has no root span yet, treat it as not found
+		return traces.Trace{}, connection.ErrTraceNotFound
+	}
+
+	return trace, nil
 }
 
 // GetTraceID implements tracedb.TraceDB.