replace path.Join with url.JoinPath

kubeshop · Aug 28, 2024 · 920f0e8 · 920f0e8
1 parent cbe91b0
commit 920f0e8
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cli/pkg/oauth/oauth.go b/cli/pkg/oauth/oauth.go
@@ -6,7 +6,7 @@ import (
 	"io"
 	"net"
 	"net/http"
-	"path"
+	neturl "net/url"
 	"sync"
 
 	"github.com/kubeshop/tracetest/cli/ui"
@@ -59,7 +59,10 @@ func (s *OAuthServer) GetAuthJWT() error {
 		return fmt.Errorf("failed to start oauth server: %w", err)
 	}
 
-	loginUrl := path.Join(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url))
+	loginUrl, err := neturl.JoinPath(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url))
+	if err != nil {
+		return fmt.Errorf("could not build path: %w", err)
+	}
 
 	ui := ui.DefaultUI
 	err = ui.OpenBrowser(loginUrl)