examples(pw): remove redundant config

kubeshop · Oct 7, 2024 · 139fa7b · 139fa7b
1 parent fd0e737
commit 139fa7b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 27 deletions.
diff --git a/examples/quick-start-playwright-test-observability-nodejs/.env.template b/examples/quick-start-playwright-test-observability-nodejs/.env.template
@@ -5,6 +5,7 @@ TRACETEST_ENVIRONMENT_ID="env"
 
 AVAILABILITY_HOST="availability"
 
+REACT_URL="http://host.docker.internal:3000/"
 REACT_APP_APP_HOST="host.docker.internal"
 REACT_APP_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://host.docker.internal:4318/v1/traces"
 

diff --git a/examples/quick-start-playwright-test-observability-nodejs/collector.config.yaml b/examples/quick-start-playwright-test-observability-nodejs/collector.config.yaml
diff --git a/examples/quick-start-playwright-test-observability-nodejs/react-app/playwright.config.js b/examples/quick-start-playwright-test-observability-nodejs/react-app/playwright.config.js
@@ -1,8 +1,8 @@
 import { defineConfig, devices } from '@playwright/test';
 import { config } from 'dotenv';
-config();
+config({ path: '../.env'});
 
-const baseURL = process.env.REACT_APP_URL || 'http://localhost:3000';
+const baseURL = process.env.REACT_URL || 'http://localhost:3000';
 
 /**
  * See https://playwright.dev/docs/test-configuration.

diff --git a/examples/quick-start-playwright-test-observability-nodejs/resources/playwright-test.yaml b/examples/quick-start-playwright-test-observability-nodejs/resources/playwright-test.yaml
@@ -19,7 +19,7 @@ spec:
         - attr:books.list.count = 3
     - selector: span[tracetest.span.type="http" name="GET /availability/:bookId" http.method="GET"]
       assertions:
-        - attr:http.host = "availability:8080"
+        - attr:http.host = "availability:8082"
     - selector: span[tracetest.span.type="general" name="Availablity check"]
       assertions:
         - attr:isAvailable = "true"