Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TKC-2995] Store default config variables #6081

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat: [TKC-2995] Store default config variables #6081

merged 1 commit into from
Dec 16, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Dec 16, 2024 •
edited
Loading

Pull request description

We now will also store default config parameter values if not provided in request

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@povilasv povilasv marked this pull request as ready for review December 16, 2024 13:53
@povilasv povilasv requested a review from a team as a code owner December 16, 2024 13:53
@rangoo94
Copy link
Member

rangoo94 commented Dec 16, 2024 •
edited
Loading

Is this required, considering we have it in resolvedWorkflow.spec.config[K].default? Not having it gives additional information - whether it has been overridden to static default, or used the default

@povilasv povilasv merged commit 3a9814b into main Dec 16, 2024
7 checks passed
@povilasv povilasv deleted the TKC-2995 branch December 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WitoDelnat WitoDelnat WitoDelnat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @rangoo94 @WitoDelnat