Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select namespace for dry-run config deploy #4168

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat: select namespace for dry-run config deploy #4168

merged 1 commit into from
Sep 25, 2023

Conversation

devcatalin
Copy link
Member

@devcatalin devcatalin commented Sep 25, 2023 •
edited
Loading

This PR...

Changes

  • allow users to select a namespace where the helm dry-run config should be deployed

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

topliceanurazvan
topliceanurazvan approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@topliceanurazvan topliceanurazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devcatalin devcatalin merged commit 429ac07 into main Sep 25, 2023
@devcatalin devcatalin deleted the devcatalin/fix/helm-deploy branch September 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topliceanurazvan topliceanurazvan topliceanurazvan approved these changes

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

@olensmar olensmar Awaiting requested review from olensmar olensmar is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devcatalin @topliceanurazvan