fix: remove pre upgrade hooks #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sandbox environment for URLs |
ed382
commented
Oct 22, 2024
| {{- if .Values.preUpgrade.resources }} | ||
| resources: {{- toYaml .Values.preUpgrade.resources | nindent 10 }} | ||
| {{- end }} | ||
| command: |
There was a problem hiding this comment.
@ypoplavs Do you know if this one is needed?
The tag we were using had 5 critical vulnerabilities and: > Images provided under gcr.io/kubebuilder/ will be unavailable from March 18, 2025. https://book.kubebuilder.io/reference/metrics
ypoplavs
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes