Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove logs as subchart #932

Closed
wants to merge 1 commit into from
Closed

fix: remove logs as subchart #932

wants to merge 1 commit into from

Conversation

ed382
Copy link
Contributor

@ed382 ed382 commented Aug 28, 2024

Pull request description

The condition to disable this is not working. Maybe because of multiple levels of dependence:

For multiple level dependencies the condition is prependend by the path to the parent chart.

https://v2.helm.sh/docs/developing_charts/#tags-and-condition-fields-in-requirements-yaml

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

The condition to disable this is not working. Maybe because of multiple levels of dependence:

> For multiple level dependencies the condition is prependend by the path to the parent chart.

https://v2.helm.sh/docs/developing_charts/#tags-and-condition-fields-in-requirements-yaml
@ed382 ed382 self-assigned this Aug 28, 2024
@ed382 ed382 requested a review from a team as a code owner August 28, 2024 14:52
@ed382 ed382 changed the base branch from main to develop August 28, 2024 14:53
@ed382 ed382 requested a review from a team as a code owner August 28, 2024 14:53
@ed382 ed382 changed the base branch from develop to main August 28, 2024 14:53
@ed382 ed382 closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant