Validate cloud connection #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
validate-cloud-connection
branch
from
464467e to
a8f6f2e
Compare
mszostok
reviewed
Feb 21, 2024
| Event: make(chan source.Event, 1), | ||
| } | ||
| out.Event <- source.Event{ | ||
| Message: unauthorizedMessage(s.openSourceBlockage), |
There was a problem hiding this comment.
I just learned during e2e demo that for source we need to add also a plugin name as otherwise you won't know which one reported that. I will fix that tomorrow.
|
If I understand this correctly - the agent always forwards messages over to plugins, right? If that's the case, shouldn't we have something similar in the agent code instead? |
|
@vaijab In theory we could build the check in agent, but the agent is fully OS, so it would be easy to avoid by running modified agent. It's harder to workaround this check if it's on the closed-source plugin side. Hope that makes sense 🙂 |
pkosiec
approved these changes
Feb 22, 2024
mszostok
force-pushed
the
validate-cloud-connection
branch
from
a8f6f2e to
12dfce7
Compare
MOD handle / display errors ADD authorized executor ADD with retry connection to cloud MOD init auth executor for doctor and flux plugin ADD auth source for source plugins FIX prometheus
1. Call cloud endpoints only if cloud envs are present (speeds up indexing) 2. Introduce a goroutine to supervise active cloud connections: 3. Replace panic with user-facing messages minor: 1. Log connection errors instead of ignoring them 2. Simplify QGL client logic 3. Fix lint issues 4. Fix helm unit-tests
mszostok
force-pushed
the
validate-cloud-connection
branch
from
12dfce7 to
ff9c7ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolve https://github.com/kubeshop/botkube-cloud/issues/881