Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate legacy teams docs #296

Merged
merged 3 commits into from
Dec 4, 2023
Merged

deprecate legacy teams docs #296

merged 3 commits into from
Dec 4, 2023

Conversation

brampling
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Deprecate legacy teams docs
  • Add banner for cloud
  • Fix Slack App naming
  • Nomenclature cleanup

Testing

Manual testing

Related issue(s)

@brampling brampling requested review from a team and madebyrogal November 30, 2023 12:39
@pkosiec pkosiec requested review from pkosiec and removed request for madebyrogal November 30, 2023 15:12
@pkosiec pkosiec self-assigned this Nov 30, 2023
pkosiec
pkosiec approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address one comment with the "Botkube Cloud Slack App" occurrence. Other comments are just some small suggestions to consider.

docs/installation/slack/index.md Outdated Show resolved Hide resolved
docs/installation/teams/index.md Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
pkosiec
pkosiec approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brampling brampling merged commit 23bb3ba into kubeshop:main Dec 4, 2023
2 checks passed
@brampling brampling deleted the teams-gtm-update branch December 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees

@pkosiec pkosiec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brampling @pkosiec