Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local container development experience #48815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve local container development experience #48815

wants to merge 2 commits into from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 23, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 23, 2024
@chalin chalin changed the title [CI] Improved Dockerfile and more flexible make targets [CI] Improved Dockerfile and more flexible container make targets Nov 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 9cc5d50
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67423f332ec2b400087f22fc
😎 Deploy Preview https://deploy-preview-48815--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 23, 2024

These changes don't have much impact on our continuous integration (which happens within Netlify), so:

/retitle Improve local container development experience

Mainly dropping the leading “[CI]” there.

@k8s-ci-robot k8s-ci-robot changed the title [CI] Improved Dockerfile and more flexible container make targets Improve local container development experience Nov 23, 2024
sftim
sftim reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dockerfile Outdated Show resolved Hide resolved
Dockerfile
COPY package.json package-lock.json ./
RUN npm ci
RUN npm ci --omit=dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can make this a multistage build and slim down the final image?

Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is going to be quite big I think. I'm OK with that, but we should note the opportunity to optimize it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35af423e293e446195b14adac31eb3599cdda432

@chalin @sftim
Update Dockerfile
9cc5d50 
Co-authored-by: Tim Bannister <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@tengqm tengqm Awaiting requested review from tengqm

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @sftim @k8s-ci-robot