Update kubelet.md #48804
Closed
Update kubelet.md #48804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-rebase
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -294,7 +294,7 @@ kubelet [flags] | |||
| <td colspan="2">--eviction-max-pod-grace-period int32</td> | |||
| </tr> | |||
| <tr> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) to use when terminating pods in response to a soft eviction threshold being met. If negative, defer to pod specified value. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value or use the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | |||
There was a problem hiding this comment.
Suggested change
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value or use the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | |
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value in the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> |
There was a problem hiding this comment.
I think it is already mentioned in the note that this option should be set in the kubelet config file.
tengqm
reviewed
Nov 24, 2024
| @@ -294,7 +294,7 @@ kubelet [flags] | |||
| <td colspan="2">--eviction-max-pod-grace-period int32</td> | |||
| </tr> | |||
| <tr> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) to use when terminating pods in response to a soft eviction threshold being met. If negative, defer to pod specified value. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | |||
| <td></td><td style="line-height: 130%; word-wrap: break-word;"> Maximum allowed grace period (in seconds) for terminating pods during soft eviction. A positive value sets an explicit grace period, while 0 results in immediate termination. When set to a negative value, the kubelet sends a -1 grace period to the CRI runtime, leading to immediate termination with a SIGKILL signal (exit code 137). To ensure predictable behavior, configure this parameter with a positive value or use the kubelet configuration file. (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | |||
There was a problem hiding this comment.
Please make sure that this is consistent to the output from kubelet --help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Fixes: # kubernetes/kubernetes#118172