CAPZ: Trigger api version upgrade scope changes #33903
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @jackfrancis |
| @@ -567,7 +567,7 @@ presubmits: | |||
| preset-kind-volume-mounts: "true" | |||
| preset-azure-community: "true" | |||
| decorate: true | |||
| run_if_changed: '^test\/e2e\/(config\/azure-dev\.yaml)|(data\/shared\/v1beta1_provider\/metadata\.yaml)$' | |||
| run_if_changed: '^(test\/e2e\/(config\/azure-dev\.yaml|data\/shared\/v1beta1_provider\/metadata\.yaml)|azure\/scope\/.*)$' | |||
There was a problem hiding this comment.
I'm concerned about the ^ and $ here now that we're adding the open-ended directory match to the end (I don't think we need to be that strict)
test\/e2e\/(config\/azure-dev\.yaml)|(data\/shared\/v1beta1_provider\/metadata\.yaml)|azure\/scope is probably sufficient
There was a problem hiding this comment.
I tested the regex here https://regex101.com/r/ah1HgX/2
^ and $ are necessary to ensure we only match test/e2e/config/azure-dev.yaml or test/e2e/data/shared/v1beta1_provider/metadata.yaml. Any changes in azure/scope/ still work.
There was a problem hiding this comment.
regex101.com si better than my personal concern :)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nawazkh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nawazkh: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR will enable
pull-cluster-api-provider-azure-apiversion-upgradetest job to run on changes inazure/scope/.*Part of kubernetes-sigs/cluster-api-provider-azure#5311. Originated from kubernetes-sigs/cluster-api-provider-azure#5311 (comment)
Part of kubernetes-sigs/cluster-api-provider-azure#5296