-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-3041] - remove node special feature and node alpha feature from test-infra for non release branch #33828
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
kannon92:remove-node-special-feature
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,42 +52,6 @@ periodics: | |
| testgrid-alert-email: [email protected] | ||
|
|
||
| description: "OWNER: sig-node; runs NodeConformance e2e tests with crio master and cgroup v1" | ||
| # TODO (https://github.com/kubernetes/test-infra/issues/26127) consider restoring once we will figure out the right set of alpha features. The tag NodeAlphaFeature is not being used any longer | ||
| # - name: ci-crio-cgroupv1-node-e2e-alpha | ||
| # cluster: k8s-infra-prow-build | ||
| # interval: 1h | ||
| # labels: | ||
| # preset-service-account: "true" | ||
| # preset-k8s-ssh: "true" | ||
| # spec: | ||
| # containers: | ||
| # - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241128-8df65c072f-master | ||
| # args: | ||
| # - --root=/go/src | ||
| # - --repo=k8s.io/kubernetes | ||
| # - "--timeout=90" | ||
| # - --scenario=kubernetes_e2e | ||
| # - -- # end bootstrap args, scenario args below | ||
| # - --deployment=node | ||
| # - --env=KUBE_SSH_USER=core | ||
| # - --gcp-zone=us-west1-b | ||
| # - '--node-test-args=--feature-gates=AllAlpha=true,RotateKubeletServerCertificate=false --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| # - --node-tests=true | ||
| # - --provider=gce | ||
| # - --test_args=--nodes=8 --focus="\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]" --skip="\[Flaky\]|\[Serial\]" | ||
| # - --runtime-config=api/all=true | ||
| # - --timeout=65m | ||
| # - --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv1.yaml | ||
| # env: | ||
| # - name: GOPATH | ||
| # value: /go | ||
| # - name: IGNITION_INJECT_GCE_SSH_PUBLIC_KEY_FILE | ||
| # value: "1" | ||
| # annotations: | ||
| # testgrid-dashboards: sig-node-cri-o | ||
| # testgrid-tab-name: ci-crio-cgroupv1-node-e2e-alpha | ||
| # testgrid-alert-email: [email protected] | ||
| # description: "OWNER: sig-node; runs NodeConformance and alpha e2e tests with crio master and cgroup v1" | ||
| - name: ci-crio-cgroupv1-node-e2e-features | ||
| cluster: k8s-infra-prow-build | ||
| interval: 1h | ||
|
|
@@ -276,7 +240,7 @@ periodics: | |
| - '--node-test-args=--container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - --node-tests=true | ||
| - --provider=gce | ||
| - --test_args=--nodes=1 --skip="\[Flaky\]|\[NodeConformance\]|\[Conformance\]|\[Serial\]|\[NodeFeature:.+\]|\[NodeFeature\]|\[Feature:.+\]|\[Feature\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[Legacy:.+\]|\[Benchmark\]|\[Feature:SCTPConnectivity\]" | ||
| - --test_args=--nodes=1 --skip="\[Flaky\]|\[NodeConformance\]|\[Conformance\]|\[Serial\]|\[NodeFeature:.+\]|\[NodeFeature\]|\[Feature:.+\]|\[Feature\]|\[Legacy:.+\]|\[Benchmark\]|\[Feature:SCTPConnectivity\]" | ||
| - --timeout=300m | ||
| - --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv1.yaml | ||
| env: | ||
|
|
@@ -295,7 +259,7 @@ periodics: | |
| testgrid-dashboards: sig-node-cri-o | ||
| testgrid-tab-name: ci-crio-cgroupv1-node-e2e-unlabelled | ||
| testgrid-alert-email: [email protected] | ||
| description: "Contains all uncategorized tests, these are tests which are not marked with a [Node] tag. All node tests should be marked with [NodeFeature] or [NodeSpecialFeature] or [NodeAlphaFeature] or [NodeConformance] classification. Also skipped are [Flaky], [Benchmark], [Legacy]." | ||
| description: "Contains all uncategorized tests, these are tests which are not marked with a [Node] tag. All node tests should be marked with [NodeFeature] or [NodeConformance] classification. Also skipped are [Flaky], [Benchmark], [Legacy]." | ||
| - name: ci-crio-cgroupv2-node-e2e-unlabelled | ||
| cluster: k8s-infra-prow-build | ||
| interval: 12h | ||
|
|
@@ -328,7 +292,7 @@ periodics: | |
| - '--node-test-args=--container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--fail-cgroupv1=true --cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - --node-tests=true | ||
| - --provider=gce | ||
| - --test_args=--nodes=1 --skip="\[Flaky\]|\[NodeConformance\]|\[Conformance\]|\[Serial\]|\[NodeFeature:.+\]|\[NodeFeature\]|\[Feature:.+\]|\[Feature\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[Legacy:.+\]|\[Benchmark\]|\[Feature:SCTPConnectivity\]" | ||
| - --test_args=--nodes=1 --skip="\[Flaky\]|\[NodeConformance\]|\[Conformance\]|\[Serial\]|\[NodeFeature:.+\]|\[NodeFeature\]|\[Feature:.+\]|\[Feature\]|\[Legacy:.+\]|\[Benchmark\]|\[Feature:SCTPConnectivity\]" | ||
| - --timeout=300m | ||
| - --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv2.yaml | ||
| env: | ||
|
|
@@ -347,7 +311,7 @@ periodics: | |
| testgrid-dashboards: sig-node-cri-o | ||
| testgrid-tab-name: ci-crio-cgroupv2-node-e2e-unlabelled | ||
| testgrid-alert-email: [email protected] | ||
| description: "Contains all uncategorized tests, these are tests which are not marked with a [Node] tag. All node tests should be marked with [NodeFeature] or [NodeSpecialFeature] or [NodeAlphaFeature] or [NodeConformance] classification. Also skipped are [Flaky], [Benchmark], [Legacy]." | ||
| description: "Contains all uncategorized tests, these are tests which are not marked with a [Node] tag. All node tests should be marked with [NodeFeature] or [NodeConformance] classification. Also skipped are [Flaky], [Benchmark], [Legacy]." | ||
| - name: ci-crio-cgroupv1-node-e2e-eviction | ||
| cluster: k8s-infra-prow-build | ||
| interval: 4h30m | ||
|
|
@@ -858,10 +822,10 @@ periodics: | |
| - --deployment=node | ||
| - --env=KUBE_SSH_USER=core | ||
| - --gcp-zone=us-west1-b | ||
| - '--node-test-args=--feature-gates="DevicePluginCDIDevices=true" --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - '--node-test-args=--container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
| - --node-tests=true | ||
| - --provider=gce | ||
| - --test_args=--focus="\[NodeSpecialFeature:CDI\]" --skip="\[Flaky\]" | ||
| - --test_args=--focus="\[Feature:DevicePluginCDIDevices\]" --skip="\[Flaky\]" | ||
| - --timeout=60m | ||
| - --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgroupv1-serial.yaml | ||
| env: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing, should we replace it with specific feature labels like
Feature:PodLevelResourceandFeature:InPlacePodVerticalScaling? This would allow us to exclude tests related to in-development features from certain jobs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the sig-node CI meeting, we discussed a strategy to submit your 2 changes. This approach would streamline the PR submission process. By replacing the generic labels
NodeAlphaFeatureandNodeSpecialFeaturewith specific feature labels, we can prioritize the submission of this PR, followed by the k/k PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was about a different item. In this case, We are skipping based on NodeSpecialFeature. I think we can drop this as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think merging the k8s PR first and then this one is sufficient..