Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2020-10-14 Part 2 #2267

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Add members 2020-10-14 Part 2 #2267

merged 2 commits into from
Oct 14, 2020

Conversation

palnabarun
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject labels Oct 14, 2020
This was referenced Oct 14, 2020
Closed
Closed
@ameukam
Copy link
Member

ameukam commented Oct 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
savitharaghunathan
savitharaghunathan reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

nikhita
nikhita approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad6bdfd into kubernetes:master Oct 14, 2020
@palnabarun palnabarun deleted the add-members-2020-10-14-ii branch May 13, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@nikhita nikhita nikhita approved these changes

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

@savitharaghunathan savitharaghunathan

@mrbobbytables mrbobbytables

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for dthorsen REQUEST: New membership for arghya88
6 participants
@palnabarun @ameukam @k8s-ci-robot @savitharaghunathan @nikhita @mrbobbytables