Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calico api server to calico cni plugin #19648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Sep 15, 2024

feat:add calico api server to calico cni plugin
FIX #19285

this pr was implememted according to https://docs.tigera.io/calico/3.26/operations/install-apiserver (Manifest Install)

Before:

$./out/minikube start --cni calico      
$kubectl api-resources | grep 'projectcalico.org'
(The result is empty)

After:

$./out/minikube start --cni calico      
# proving the api server is running
$ kubectl get pods -n calico-apiserver    
NAME                               READY   STATUS    RESTARTS      AGE
calico-apiserver-cb6754675-c4tlc   1/1     Running   1 (17s ago)   26s
$kubectl api-resources | grep 'projectcalico.org'
 kubectl api-resources | grep 'projectcalico.org'
bgpconfigurations                                crd.projectcalico.org/v1          false        BGPConfiguration
bgpfilters                                       crd.projectcalico.org/v1          false        BGPFilter
bgppeers                                         crd.projectcalico.org/v1          false        BGPPeer
blockaffinities                                  crd.projectcalico.org/v1          false        BlockAffinity
caliconodestatuses                               crd.projectcalico.org/v1          false        CalicoNodeStatus
clusterinformations                              crd.projectcalico.org/v1          false        ClusterInformation
felixconfigurations                              crd.projectcalico.org/v1          false        FelixConfiguration
globalnetworkpolicies                            crd.projectcalico.org/v1          false        GlobalNetworkPolicy
globalnetworksets                                crd.projectcalico.org/v1          false        GlobalNetworkSet
hostendpoints                                    crd.projectcalico.org/v1          false        HostEndpoint
ipamblocks                                       crd.projectcalico.org/v1          false        IPAMBlock
ipamconfigs                                      crd.projectcalico.org/v1          false        IPAMConfig
ipamhandles                                      crd.projectcalico.org/v1          false        IPAMHandle
ippools                                          crd.projectcalico.org/v1          false        IPPool
ipreservations                                   crd.projectcalico.org/v1          false        IPReservation
kubecontrollersconfigurations                    crd.projectcalico.org/v1          false        KubeControllersConfiguration
networkpolicies                                  crd.projectcalico.org/v1          true         NetworkPolicy
networksets                                      crd.projectcalico.org/v1          true         NetworkSet

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2024
@ComradeProgrammer
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 15, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Sep 17, 2024

@ComradeProgrammer can u plz fix the lint

@medyagh medyagh changed the title feat:add calico api server to calico cni plugin add calico api server to calico cni plugin Sep 18, 2024
pkg/minikube/cni/calico-apiserver.yaml Outdated Show resolved Hide resolved
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

hack/update/calico_version/update_calico_version.go Outdated Show resolved Hide resolved
hack/update/calico_version/update_calico_version.go Outdated Show resolved Hide resolved
hack/update/calico_version/update_calico_version.go Outdated Show resolved Hide resolved
hack/update/calico_version/update_calico_version.go Outdated Show resolved Hide resolved
pkg/minikube/cni/calico-apiserver.yaml Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19648) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 48.2s               |
| enable ingress | 15.3s    | 15.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 50.2s 49.7s 48.2s 49.9s
Times for minikube (PR 19648) start: 46.5s 48.0s 46.3s 49.2s 51.2s

Times for minikube (PR 19648) ingress: 14.5s 14.5s 16.0s 15.0s 18.6s
Times for minikube ingress: 16.0s 15.0s 16.0s 15.0s 14.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19648) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 22.5s               |
| enable ingress | 13.1s    | 13.4s               |
+----------------+----------+---------------------+

Times for minikube start: 19.8s 20.8s 20.9s 23.8s 20.6s
Times for minikube (PR 19648) start: 20.6s 23.6s 21.1s 23.9s 23.4s

Times for minikube ingress: 13.3s 13.3s 13.3s 12.8s 12.8s
Times for minikube (PR 19648) ingress: 12.8s 13.3s 13.8s 13.3s 13.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19648) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.0s               |
| enable ingress | 23.4s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.2s 23.0s 22.1s 20.4s
Times for minikube (PR 19648) start: 19.8s 22.4s 22.2s 20.3s 20.3s

Times for minikube ingress: 22.8s 23.3s 23.8s 24.3s 22.8s
Times for minikube (PR 19648) ingress: 22.8s 38.8s 23.8s 22.8s 22.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio (1 failed) TestAddons/parallel/CSI(gopogh) 1.15% (chart)
Docker_Windows (3 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 44.64% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

env:
- name: DATASTORE_TYPE
value: kubernetes
image: {{ .APIServerImageName }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might need be to be a If statement( like a golang template ) simmilar to the addons. and I think the idea is if someone chooses China or whatever registery they have it should try to pull the image from there.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'--cni calico' should install the Calico API server
5 participants