-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add calico api server to calico cni plugin #19648
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5a5b9bb
to
584241d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ComradeProgrammer can u plz fix the lint |
2031677
to
19ffff6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
19ffff6
to
536fc85
Compare
Co-authored-by: Steven Powell <[email protected]>
kvm2 driver with docker runtime
Times for minikube start: 49.8s 50.2s 49.7s 48.2s 49.9s Times for minikube (PR 19648) ingress: 14.5s 14.5s 16.0s 15.0s 18.6s docker driver with docker runtime
Times for minikube start: 19.8s 20.8s 20.9s 23.8s 20.6s Times for minikube ingress: 13.3s 13.3s 13.3s 12.8s 12.8s docker driver with containerd runtime
Times for minikube start: 22.4s 21.2s 23.0s 22.1s 20.4s Times for minikube ingress: 22.8s 23.3s 23.8s 24.3s 22.8s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
env: | ||
- name: DATASTORE_TYPE | ||
value: kubernetes | ||
image: {{ .APIServerImageName }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might need be to be a If statement( like a golang template ) simmilar to the addons. and I think the idea is if someone chooses China or whatever registery they have it should try to pull the image from there.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
feat:add calico api server to calico cni plugin
FIX #19285
this pr was implememted according to https://docs.tigera.io/calico/3.26/operations/install-apiserver (Manifest Install)
Before:
After: