Only set containerd plugins on kops versions that include quote fixes #16133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
hakman
approved these changes
Nov 30, 2023
k8s-ci-robot
added
the
lgtm
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
On that note, is it worth running the kops e2e tests from release branches to avoid these problems? |
Release branches are unreliable, because artifacts get removed after 1-2 months. |
|
🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16056 broke jobs that use any kops build that doesn't include #16128 (example). Until we can implement #16084 we can guard the new --set assignment behind a kops version check.
This will eval to true for all 1.29 builds. We dont have any jobs that test 1.29 prereleases (which dont include #16128) we only have jobs that test CI builds of the kops master branch, so any kops 1.29 job will include the quote fix.