Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners.md: cleanup outdated links / stale gubernator reference #7920

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 30, 2024

Should avoid to the next maintainer looking at OWNERS files docs to needlessy avoid filters for use with approvers

  • gubernator reference cleanup
  • followup to 0fc7f16 : clean up leftover links.

/sig contribex

@k8s-ci-robot
Copy link
Contributor

@VannTen: The label(s) sig/contribex cannot be applied, because the repository doesn't have them.

In response to this:

Should avoid to the next maintainer looking at OWNERS files docs to needlessy avoid filters for use with approvers

/sig contribex

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/contributor-guide Issues or PRs related to the contributor guide labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label May 30, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
The PR dashboard now responds with a 404, it was retired some time ago.
@VannTen VannTen force-pushed the cleanup/update_stale_owners_docs branch from fddf661 to 3be1ea8 Compare August 26, 2024 13:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2024
@Priyankasaggu11929
Copy link
Member

/remove-lifecycle stale

/assign @mrbobbytables
for approval

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Nov 25, 2024

This PR originally included something similar to 0fc7f16 , I hadn't notice that the needs-rebase was because that commit was included ; and doing the rebase made the PR description out of sync with it's content.

@VannTen VannTen changed the title Update stale docs about OWNERS files owners.md: cleanup outdated links / stale gubernator reference Nov 25, 2024
@Priyankasaggu11929
Copy link
Member

This PR originally included something similar to 0fc7f16 , I hadn't notice that the needs-rebase was because that commit was included ; and doing the rebase made the PR description out of sync with it's content.

Thanks for the clarification, @VannTen

(I think I can approve too, trying)
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 27, 2024
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, Priyankasaggu11929, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 36e013e into kubernetes:master Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants