-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add recommender vpa-object-namespace quick integration test #7769
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: phuhung273 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @phuhung273! |
Hi @phuhung273. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
487ead7
to
0de1fca
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I have a few comments, though I haven’t tested it yet.
Could you create a directory under hack
to store everything?
For example: autoscaler/vertical-pod-autoscaler/hack/integration-tests
.
Once that's done, we can work on integrating it into our CI.
vertical-pod-autoscaler/hack/e2e/deploy/recommender/vpa-object-namespace.sh
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/hack/e2e/deploy/recommender/ignored-vpa-object-namespaces.sh
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/hack/e2e/deploy/recommender/ignored-vpa-object-namespaces.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, and it looks good! There is still more work to do, but that can be done later. This PR helps a lot with test coverage and makes it easier to add more tests in the future so overall I like it - thanks!
@adrianmoisey, can you take a look too?
Also, I think we should write this down somewhere so contributors know how to add tests easily.
/remove-kind feature |
I like the idea of having the quick tests, or, a way to execute a subset of e2e tests for taster feedback. What concerns me is that these tests use shell scripts, rather than ginkgo, to execute. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
recommender
flags:vpa-object-namespace
,ignored-vpa-object-namespaces
Which issue(s) this PR fixes:
Fixes #7699
Relates #7723
Special notes for your reviewer:
This PR doesn't include:
I left some TODOs in the script
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: