Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Add forking functionality from krel release-notes #13

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

justaugustus
Copy link
Member

The ability to create forks was reused in krel promote-images,
which is now being moved into sigs.k8s.io/promo-tools as
kpromo pr: kubernetes-sigs/promo-tools#458

Given the functionality has proven to be useful in multiple places,
we'll move it here so it can be leveraged for other tools.

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @xmudrii @Verolop
cc: @kubernetes-sigs/release-engineering

The ability to create forks was reused in `krel promote-images`,
which is now being moved into sigs.k8s.io/promo-tools as
`kpromo pr`.

Given the functionality has proven to be useful in multiple places,
we'll move it here so it can be leveraged for other tools.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021
@puerco
Copy link
Member

puerco commented Nov 18, 2021

Thinking a little bit about these functions that relate to forking, much of the code relies on github apis, but if you think about it the functions are more git specific. For example, things like github.BranchExists() are in essence GitHub API laziness for looking into the git ls-remote output 🤔 WDYT?

@puerco
Copy link
Member

puerco commented Nov 18, 2021

The downside of course is that we would have to implement some of the github code in git which is in practice pointless as we already have the functionality.

@justaugustus
Copy link
Member Author

Thinking a little bit about these functions that relate to forking, much of the code relies on github apis, but if you think about it the functions are more git specific. For example, things like github.BranchExists() are in essence GitHub API laziness for looking into the git ls-remote output 🤔 WDYT?

The downside of course is that we would have to implement some of the github code in git which is in practice pointless as we already have the functionality.

@puerco -- Hmmm, I think we should defer that discussion til when we tackle this issue: #4

@puerco
Copy link
Member

puerco commented Nov 18, 2021

we should defer that discussion til when we tackle this issue: #4

Hehe I was precisely writing that :) let's get them to support the other PRs and then consider building those two functions in pure git.
/lgtm

BTW: From recent experiences from work I'm starting to have second thoughts about #4

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 41c2d3a into kubernetes-sigs:main Nov 18, 2021
@justaugustus
Copy link
Member Author

we should defer that discussion til when we tackle this issue: #4

Hehe I was precisely writing that :) let's get them to support the other PRs and then consider building those two functions in pure git.

BTW: From recent experiences from work I'm starting to have second thoughts about #4

Hehe, I know what you mean about #4.
Cross-linking the convos for history: #4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants