-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Add forking functionality from krel release-notes
#13
Conversation
The ability to create forks was reused in `krel promote-images`, which is now being moved into sigs.k8s.io/promo-tools as `kpromo pr`. Given the functionality has proven to be useful in multiple places, we'll move it here so it can be leveraged for other tools. Signed-off-by: Stephen Augustus <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thinking a little bit about these functions that relate to forking, much of the code relies on github apis, but if you think about it the functions are more git specific. For example, things like |
The downside of course is that we would have to implement some of the github code in git which is in practice pointless as we already have the functionality. |
@puerco -- Hmmm, I think we should defer that discussion til when we tackle this issue: #4 |
Hehe, I know what you mean about #4. |
The ability to create forks was reused in
krel promote-images
,which is now being moved into sigs.k8s.io/promo-tools as
kpromo pr
: kubernetes-sigs/promo-tools#458Given the functionality has proven to be useful in multiple places,
we'll move it here so it can be leveraged for other tools.
Signed-off-by: Stephen Augustus [email protected]
/assign @puerco @xmudrii @Verolop
cc: @kubernetes-sigs/release-engineering