-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws sdk code from v1 to v2 #322
Update aws sdk code from v1 to v2 #322
Conversation
Signed-off-by: Davanum Srinivas <[email protected]>
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @stevekuznetsov @krzyzacy |
Signed-off-by: Davanum Srinivas <[email protected]>
b1c1477
to
77dc7b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
do you also need to update the underlying job configs? (not too familiar with aws sdk :-) )
@krzyzacy we use a custom format for the creds config - https://github.com/dims/prow/blob/b21d1cf485474d6da2623ccc40849e2c8b24b2e5/pkg/io/providers/providers.go#L97-L107 So i don't think we need any changes in the job configs (famous last words!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sounds like something that should be merged when k8s Prow admins are aware and can report back any issues.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, krzyzacy, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@petr-muller @krzyzacy i am one of the folks who keep an eye on things failing. want to land this (and happy to revert immediately if anything fails). I am NOT at kubecon as well, might as well do this exercise before folks return from there. |
lol sorry I meant to let you unhold yourself, but /unhold |
Tested the method
getS3Bucket
locally using work credentials (emptys3Credentials
essentially)had to update
gocloud.dev/blob
to a version that supports aws sdk v2xref: #212