Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws sdk code from v1 to v2 #322

Merged

Conversation

dims
Copy link
Member

@dims dims commented Nov 12, 2024

Tested the method getS3Bucket locally using work credentials (empty s3Credentials essentially)

had to update gocloud.dev/blob to a version that supports aws sdk v2

xref: #212

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 77dc7b7
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67338e8d8347d5000882f231
😎 Deploy Preview https://deploy-preview-322--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2024
@dims
Copy link
Member Author

dims commented Nov 12, 2024

cc @micahhausler

@dims
Copy link
Member Author

dims commented Nov 12, 2024

/assign @stevekuznetsov @krzyzacy

Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the update-aws-sdk-code-from-v1-to-v2 branch from b1c1477 to 77dc7b7 Compare November 12, 2024 17:21
Copy link
Contributor

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

do you also need to update the underlying job configs? (not too familiar with aws sdk :-) )

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2024
@dims
Copy link
Member Author

dims commented Nov 12, 2024

@krzyzacy we use a custom format for the creds config - https://github.com/dims/prow/blob/b21d1cf485474d6da2623ccc40849e2c8b24b2e5/pkg/io/providers/providers.go#L97-L107

So i don't think we need any changes in the job configs (famous last words!)

Copy link
Contributor

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sounds like something that should be merged when k8s Prow admins are aware and can report back any issues.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, krzyzacy, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [krzyzacy,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Nov 13, 2024

@petr-muller @krzyzacy i am one of the folks who keep an eye on things failing. want to land this (and happy to revert immediately if anything fails). I am NOT at kubecon as well, might as well do this exercise before folks return from there.

@krzyzacy
Copy link
Contributor

lol sorry I meant to let you unhold yourself, but :shipit:

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0609cf5 into kubernetes-sigs:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants