-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support copy repository to custom directory #214
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CarlJi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @CarlJi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test all
👋 can you describe what kind of scenarios are you interested in? The client library is able to checkout multiple repositories (via multiple |
Hi @petr-muller, thanks for your feedback. In this project, we utilize prow git library to prepare a clean code workspace for PR in order to do all kinds of linters check. The need for this capability arises from our utilization of replace in go.mod to reference certain private repositories, for example: replace github.com/qiniu/log.v1 => ../kodo/src/github.com/qiniu/log.v1
replace github.com/qiniu/errors => ../kodo/src/github.com/qiniu/errors In this context, Another, our project has config like this. so with this functionality, I can address this scenario like the following: - |
cd .. && git clone xxx && cd -
golangci-lint xxx It will be very straightforward.
Seems that this is the actual code directory, the real workspace. i am thinking It would be more elegant with such capability. |
/test all |
/ok-to-test |
0a2d808
to
bebdfa4
Compare
After deeper reflection and practice, I am considering the possibility of directly supporting "Copy to custom directory," which might be more elegant. This approach should be able to accommodate a wider range of use cases. Please help review @petr-muller @krzyzacy |
I'm still catching up on the latest Prow changes, previously we leverage |
Yes, The background context is that I am building a unified linters runner to standardize engineering practices across multiple orgs and numerous repositories. Compared to configuring Prow jobs for each repository, a centralized, low-configuration, and observable service would be more convenient for me. Of course, I still choose to use some of Prow's foundational packages, as they are indeed very useful. |
Where do we set this option? From your own controllers? I would suggest open an issue with the descriptions or your use case, and then associate your PR to the issue :-) Could you also add a unit test to assert the behavior? |
Prow and its library are quite friendly to CI infrastructure, and we have been using them extensively.
This PR aims to enhance the customization capability of its code workspace, similar to Jenkins's
checkout to sub-directory
feature. This way, within the same workspace, there will be opportunities to accommodate more repositories to address complex scenarios.