-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Policy Assistant] translate could grab labels from other pods #268
fix: [Policy Assistant] translate could grab labels from other pods #268
Conversation
Signed-off-by: Hunter Gregory <[email protected]>
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
/ok-to-test |
Signed-off-by: Hunter Gregory <[email protected]>
1affe01
to
433557b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, huntergregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes a bug in
policy-assistant analyze --mode walkthrough
resulting in incorrect policy verdicts becauseTranslate()
could return Pod B's metadata when translating Pod A.This was a bug of variable scope for
workloadOwner
andworkloadKind
. This PR moves variables closer to their usage at the proper scope.