Bump to 1.31.2 kube #256
Bump to 1.31.2 kube #256
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tssurya
force-pushed
the
bump-kube-1.31
branch
from
8df3d68
to
d76b811
Compare
k8s-ci-robot
added
size/XXL
tssurya
force-pushed
the
bump-kube-1.31
branch
5 times, most recently
from
519b830
to
d2e6f93
Compare
|
hmmm bumping stuff to newer versions breaks the tests, let me dig into why this is the case.. |
|
closing and reopening PR to re-trigger CI |
|
this time tests are passing except for one half of them... so its better than last time, |
.github/workflows/conformance.yml
Outdated
| @@ -79,7 +79,7 @@ jobs: | |||
| /usr/local/bin/kubectl apply -f ./config/crd/experimental/policy.networking.k8s.io_adminnetworkpolicies.yaml | |||
| /usr/local/bin/kubectl apply -f ./config/crd/experimental/policy.networking.k8s.io_baselineadminnetworkpolicies.yaml | |||
| # install kube-network-policies | |||
| /usr/local/bin/kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/kube-network-policies/v0.2.0/install-anp.yaml | |||
| /usr/local/bin/kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/kube-network-policies/main/install-anp.yaml | |||
There was a problem hiding this comment.
installing an unversioned file from knp seems like it will cause problems at some point
There was a problem hiding this comment.
yeah @aojea will cut a release soon.. waiting for that, this was in the interim to see if master fixed the bug we were seeing..
There was a problem hiding this comment.
There was a problem hiding this comment.
@aojea how does kube-network-policies get consumed into KIND? so which version of k-net-pol does kind 0.24 use?
There was a problem hiding this comment.
This is fixed at HEAD in kind and will be part of the next kind release.
You can see in the PR https://github.com/kubernetes-sigs/kind/pull/3761/files that kube-network-policies is also a library, so it gets vendored in the kindnet version of kind
There was a problem hiding this comment.
ETA for a new release of kind = kubecon 😄
There was a problem hiding this comment.
@tssurya ben just released a new version of kind , it should work with the new version
There was a problem hiding this comment.
we are looking good here, @aojea or @danwinship would one of you like to approve this?
tssurya
force-pushed
the
bump-kube-1.31
branch
2 times, most recently
from
e661407
to
5aa0647
Compare
Signed-off-by: Surya Seetharaman <[email protected]>
tssurya
force-pushed
the
bump-kube-1.31
branch
from
5aa0647
to
483d905
Compare
|
/lgtm Thanks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Routine bump to 1.31.2