-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change proxmox ve image output format to raw from qcow2 #1636
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @stenwt! |
Hi @stenwt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@mcbenjemaa as you introduced the format initially are you able to comment on this? I'm not sure which is correct but I know the Proxmox builds have been previously working so curious as to why this PR is needed now. |
On the contrary, the format qcow2 is fine and works with Proxmox VE. Format qcow2 makes more sense, and is a bit faster when cloning images. When we provision clusters with CAPI. |
Change description
Changes proxmox image output format from qcow2, which proxmox does not accept, to raw, which it does
Related issues
Additional context
log output after change: