Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatcar build for Proxmox #1589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcbenjemaa
Copy link
Member

Change description

This PR adds:

  • Flatcar build for Proxmox

Related issues

  • Fixes #

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2024
@mcbenjemaa mcbenjemaa marked this pull request as draft October 11, 2024 15:19
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
@mcbenjemaa
Copy link
Member Author

The build is working, but let me double check for any findings.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@mcbenjemaa mcbenjemaa marked this pull request as ready for review October 23, 2024 11:40
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 23, 2024
@mcbenjemaa
Copy link
Member Author

WIP in CAPMOX
ionos-cloud/cluster-api-provider-proxmox#308

but I will provide a link to how this works in the provider once it is released.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@mcbenjemaa mcbenjemaa force-pushed the proxmox-flatcar branch 2 times, most recently from 8190ae6 to b79e31a Compare November 14, 2024 09:26
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2024
@mboersma
Copy link
Contributor

/retest

@AverageMarcus
Copy link
Member

@mboersma @drew-viles What do y'all think about this currently requiring the use of the Alpha Flatcar builds? I'm kinda inclined to not include this in image-builder until it's available in the Stable channel but I'm open to being convinced otherwise.

@mcbenjemaa
Copy link
Member Author

The PROXMOX VE image, was tested really well with a lot of parties.
And is being added to the alpha channel as that the release process.

On the other hand The image builder has the ability to set Flatcar Channel,
Well in that case if you only accept stable Channel, there is no need for that variable.
i.e. I tried to use the features provided.

@AverageMarcus
Copy link
Member

I'm more concerned about it defaulting to Alpha channel.

If user chose to use non-stable channels that's fine but I think the out-of-the-box settings should encourage stability. (Especially true as we're not in a position to provide any support or testing for Proxmox and very limited for Flatcar so if anyone has any issues they are often on their own)

@mcbenjemaa
Copy link
Member Author

@tormath1, if you want to add anything here.

@mcbenjemaa
Copy link
Member Author

capmox will have the support soon.
ionos-cloud/cluster-api-provider-proxmox#308

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Currently, Proxmox support is only available in the alpha channel of Flatcar.

I don't have a problem introducing this build target as an alpha feature, so long as the goal is to move this to a stable channel by default as @AverageMarcus suggested. Having said that, we don't have a way to test this in CI or locally, so all I can say is it looks good to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@mboersma
Copy link
Contributor

@drew-viles @jsturtevant do either of you have time to look at this as well?

(@AverageMarcus is away until 2025, so I may ask for more review help, or just lgtm+approve a bunch of things myself, mea culpa.)

@mboersma
Copy link
Contributor

/hold

@mcbenjemaa could you squash the commits?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@drew-viles
Copy link
Contributor

In terms of running the alpha as the default, I have no major opinion on it as I don't use flatcar so can't really comment on the stability of the alpha. It seems a bit brave but if it's been tested and we can be sure it stays stable enough I'm happy to go with the crowd.

I'm back from vacation now but will be out again in 2 weeks until Jan so get all the PRs you can in over those two weeks 🤣

I can approved once the squash has happened

@tormath1
Copy link
Contributor

Hi, regarding Alpha channel concerns, this will not be true anymore. In a few days, we will promote the Proxmox feature to "Beta" and we are confident enough to encourage folks to run a few Beta nodes in their workloads.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@mcbenjemaa
Copy link
Member Author

Squash is done,
I will make sure to update the docs when the Proxmox VE will be in the Beta channel.

@tormath1
Copy link
Contributor

Squash is done, I will make sure to update the docs when the Proxmox VE will be in the Beta channel.

Now live. 🙏

@drew-viles
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@drew-viles
Copy link
Contributor

If everyone is happy now we can unhold and merge this.

try flatcar

try flatcar -2

fix comment

sort jsonm

Build Proxmox flatcar with openstack OEM

Add scsi controller and write docs

Flatcar for Proxmox VE
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from drew-viles. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mcbenjemaa
Copy link
Member Author

Documentation updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants