🌱 Drop ReconcileError events #11341
Merged
🌱 Drop ReconcileError events #11341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6fcde2f345966316a723c240476bf577227e0f50
|
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-drop-reconciler-events
branch
from
550b9dd to
9e5ac69
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 082cf7064d0641f1505522fbc5508dee390f292c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
I think we should not publish events every time we get a reconcile errors. This can be very very spamy
Note: We have exponential backoff, but Reconcile will still be additionally triggered by updates on watched events.
P.S. There's another occurence of this, but Fabrizio will take care of that one in #11338
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #