Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.7.4 #10845

Merged
merged 1 commit into from
Jul 9, 2024
Merged

🚀 Release v1.7.4 #10845

merged 1 commit into from
Jul 9, 2024

Conversation

vishalanarase
Copy link
Member

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2024
@sbueringer
Copy link
Member

/lgtm

so far. We might have 1-2 more PRs until the release tomorrow. I'll comment accordingly

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 119010525c1b91fc80e68f3b3597da0c72cd7d25

sbueringer
sbueringer reviewed Jul 8, 2024
View reviewed changes
CHANGELOG/v1.7.4.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer July 9, 2024 05:59
@vishalanarase
🚀 Release v1.7.4
466c063 
Signed-off-by: Vishal Anarase <[email protected]>
adilGhaffarDev
adilGhaffarDev reviewed Jul 9, 2024
View reviewed changes
CHANGELOG/v1.7.4.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
if we don't get any new PRs this should be good to go in.
@Sunnatillo @chandankumar4 please take a look

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 373d1083c3f17035b2589d9c345a9e283e4b9f64

chandankumar4
chandankumar4 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@chandankumar4: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024
@sbueringer
Copy link
Member

Thx!!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
Sunnatillo
Sunnatillo reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adilGhaffarDev
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit ffb86c5 into kubernetes-sigs:main Jul 9, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments

@sbueringer sbueringer sbueringer left review comments

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@jayesh-srivastava jayesh-srivastava Awaiting requested review from jayesh-srivastava

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@sbueringer sbueringer

@adilGhaffarDev adilGhaffarDev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
6 participants
@vishalanarase @sbueringer @k8s-ci-robot @adilGhaffarDev @chandankumar4 @Sunnatillo