Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update Proxmox quick-start docs #10777

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Jun 18, 2024

What this PR does / why we need it:

This PR updates the quickstart docs for Proxmox Provider:

  • Remove the addition of IPAM provider in-cluster into clusterctl config as the IPAM provider got included in clusterctl.
  • Add new note regarding the Proxmox credentials

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation
/cherry-pick release-1.7

@k8s-ci-robot
Copy link
Contributor

@mcbenjemaa: The label(s) area/book cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

This PR updates the quickstart docs for Proxmox Provider:

  • Remove the addition of IPAM provider in-cluster into clusterctl config as the IPAM provider got included in clusterctl.
  • Add new note regarding the Proxmox credentials

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area book
/cherry-pick release1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot requested review from elmiko and JoelSpeed June 18, 2024 11:22
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2024
@mcbenjemaa
Copy link
Member Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Jun 18, 2024
@mcbenjemaa
Copy link
Member Author

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@mcbenjemaa: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small wording nit

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from chrischdi June 18, 2024 11:43
Co-authored-by: Christian Schlotter <[email protected]>
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9210563fcc7b11e9e328800e24f0de26611b6b0a

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 59a4531 into kubernetes-sigs:main Jun 18, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jun 18, 2024
@k8s-infra-cherrypick-robot

@mcbenjemaa: new pull request created: #10779

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants