Reduce log level of noisy logs in ExtensionConfig and topology Cluste…

…r controller Signed-off-by: Stefan Büringer [email protected]
kubernetes-sigs · Jan 10, 2025 · 359fc99 · 359fc99
1 parent 7f2a8cd
commit 359fc99
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/exp/runtime/internal/controllers/extensionconfig_controller.go b/exp/runtime/internal/controllers/extensionconfig_controller.go
@@ -166,7 +166,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 	}
 
 	// Register the ExtensionConfig if it was found and patched without error.
-	log.Info("Registering ExtensionConfig information into registry")
+	log.V(4).Info("Registering ExtensionConfig information into registry")
 	if err = r.RuntimeClient.Register(discoveredExtensionConfig); err != nil {
 		return ctrl.Result{}, errors.Wrapf(err, "failed to register ExtensionConfig %s/%s", extensionConfig.Namespace, extensionConfig.Name)
 	}
@@ -246,7 +246,7 @@ func reconcileCABundle(ctx context.Context, client client.Client, config *runtim
 	}
 	secretName := splitNamespacedName(secretNameRaw)
 
-	log.Info(fmt.Sprintf("Injecting CA Bundle into ExtensionConfig from secret %q", secretNameRaw))
+	log.V(4).Info(fmt.Sprintf("Injecting CA Bundle into ExtensionConfig from secret %q", secretNameRaw))
 
 	if secretName.Namespace == "" || secretName.Name == "" {
 		return errors.Errorf("failed to reconcile caBundle: secret name %q must be in the form <namespace>/<name>", secretNameRaw)

diff --git a/internal/controllers/topology/cluster/reconcile_state.go b/internal/controllers/topology/cluster/reconcile_state.go
@@ -61,9 +61,6 @@ const (
 // the entire reconcile operation will fail. This might be improved in the future if support for reconciling
 // subset of a topology will be implemented.
 func (r *Reconciler) reconcileState(ctx context.Context, s *scope.Scope) error {
-	log := ctrl.LoggerFrom(ctx)
-	log.Info("Reconciling state for topology owned objects")
-
 	// Reconcile the Cluster shim, a temporary object used a mean to collect
 	// objects/templates that can be orphaned in case of errors during the
 	// remaining part of the reconcile process.

diff --git a/internal/runtime/client/client.go b/internal/runtime/client/client.go
@@ -92,7 +92,7 @@ func (c *client) IsReady() bool {
 
 func (c *client) Discover(ctx context.Context, extensionConfig *runtimev1.ExtensionConfig) (*runtimev1.ExtensionConfig, error) {
 	log := ctrl.LoggerFrom(ctx)
-	log.Info("Performing discovery for ExtensionConfig")
+	log.V(4).Info("Performing discovery for ExtensionConfig")
 
 	hookGVH, err := c.catalog.GroupVersionHook(runtimehooksv1.Discovery)
 	if err != nil {