✨ Add ability to configure data disk provision type during clone #3332
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @vr4manta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
apis/v1beta1/types.go
Outdated
| // provisioningType specifies the provisioning type to be used for creating this disk for VirtualMachine. | ||
| // This does not apply to PersistentVolumeClaim volumes that are created and managed externally. | ||
| // If not set, the setting will be provided by the default storage policy. | ||
| // +optional |
There was a problem hiding this comment.
| // provisioningType specifies the provisioning type to be used for creating this disk for VirtualMachine. | |
| // This does not apply to PersistentVolumeClaim volumes that are created and managed externally. | |
| // If not set, the setting will be provided by the default storage policy. | |
| // +optional | |
| // provisioningType specifies the provisioning type of the disk. | |
| // This does not apply to PersistentVolumeClaim volumes that are created and managed externally. | |
| // If not set, the setting will be provided by the default storage policy. | |
| // +optional |
Question: how does it come to the PVC reference here? Don't get the relation on why we should mention that part here?
There was a problem hiding this comment.
I was changing this one too. Let me compare what i change to this suggestion
k8s-ci-robot
added
ok-to-test
|
/test help |
|
@chrischdi: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @neolit123 @rikatz in case you want to take a look |
|
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
vr4manta
force-pushed
the
SPLAT-2000_provision_type
branch
3 times, most recently
from
3e83693 to
da5756b
Compare
test/e2e/data/infrastructure-vsphere-govmomi/main/multi-disk/data-disks-patch.yaml
Outdated
Show resolved
Hide resolved
vr4manta
force-pushed
the
SPLAT-2000_provision_type
branch
from
da5756b to
9452322
Compare
|
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
|
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
sbueringer
added
the
tide/merge-method-squash
|
/lgtm /assign @chrischdi |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 127ad5e24d68d9a3ac7d447341a4fd3612bcc609
|
|
/retest |
What this PR does / why we need it:
The current implementation of the data disk feature for creating additional disks on a VirtualMachine dynamically is currently coded to create each disk as a thin provisioned disk. This may not be suitable for all scenarios. Administators may require the full disk be allocated (and possibly zeroed out). This PR is adding a new field to allow the administrators to create data disk that is either:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #