Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e: add NodeDrain e2e test #3277

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

  • Adds the node drain e2e test from CAPI
  • Adds functions to also cover waiting for volumes blocked by csi

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@chrischdi chrischdi force-pushed the pr-test-csi-volumedetach branch from bdc5331 to fb1d71a Compare December 4, 2024 09:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@chrischdi chrischdi force-pushed the pr-test-csi-volumedetach branch from c5e8bba to 064df73 Compare December 4, 2024 09:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
test/go.mod Show resolved Hide resolved
test/e2e/node_drain_test.go Outdated Show resolved Hide resolved
@chrischdi chrischdi changed the title 🌱 [WIP] e2e: add NodeDrain e2e test 🌱 e2e: add NodeDrain e2e test Dec 4, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 102b4126384d703ec80c30d6adb1f9502b7f9c22

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 789112c into kubernetes-sigs:main Dec 4, 2024
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Dec 4, 2024
@chrischdi
Copy link
Member Author

/cherry-pick release-1.12

@k8s-infra-cherrypick-robot

@chrischdi: #3277 failed to apply on top of branch "release-1.12":

Applying: e2e: add NodeDrain e2e test
Applying: fix timeout
Applying: Bump CAPI
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	packaging/go.mod
M	packaging/go.sum
M	test/e2e/config/vsphere.yaml
M	test/go.mod
M	test/go.sum
Falling back to patching base and 3-way merge...
Auto-merging test/go.sum
CONFLICT (content): Merge conflict in test/go.sum
Auto-merging test/go.mod
Auto-merging test/e2e/config/vsphere.yaml
Auto-merging packaging/go.sum
CONFLICT (content): Merge conflict in packaging/go.sum
Auto-merging packaging/go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0003 Bump CAPI

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


// deployEvictablePod will deploy a StatefulSet on a ControlPlane or MachineDeployment.
// It will deploy one Pod replica to each Machine.
func deployEvictablePod(ctx context.Context, input deployEvictablePodInput) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why statefulset instead of deployment? (just curious)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants