-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Adds links to CRD documentation on doc.crds.dev #2959
📖 Adds links to CRD documentation on doc.crds.dev #2959
Conversation
|
Welcome @berlin-ab! |
Hi @berlin-ab. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8109134
to
caa5d61
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: 12e299c7d9d8cdc0b21adaa2b5437f2a84b74ef0
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We justed merged this PR to fix another link: #2958 I'll try a re-run of the linkchecker if that doesn't work we'll need a rebase onto latest main |
@berlin-ab Looks like we need a rebase (apparently the action doesn't merge against main before running the link checker) |
This provides easy reference to developers to familiarize themselves with the types provided by cluster-api-provider-vsphere and the types provided by cluster-api.
caa5d61
to
0c99dbf
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4937e6f52b9c10022d3420829d708c05d1c0f116
|
This provides easy reference to developers to familiarize themselves with the types provided by cluster-api-provider-vsphere and the types provided by cluster-api.
What this PR does / why we need it: