Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Finalize CAPI v1.6.0-beta.1 bump & diagnostics implementation #2498

Merged
merged 1 commit into from
Nov 21, 2023
Merged

🌱 Finalize CAPI v1.6.0-beta.1 bump & diagnostics implementation #2498

merged 1 commit into from
Nov 21, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 13, 2023 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2356

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi

@sbueringer sbueringer force-pushed the pr-finalize-diagnostics-addr branch from 44c1704 to af09f7f Compare November 13, 2023 15:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cca301) 63.81% compared to head (16d552a) 63.79%.
Report is 25 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
- Coverage   63.81%   63.79%   -0.02%     
==========================================
  Files         123      123              
  Lines        8746     8767      +21     
==========================================
+ Hits         5581     5593      +12     
- Misses       2754     2758       +4     
- Partials      411      416       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrischdi
chrischdi reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@sbueringer
Copy link
Member Author

@chrischdi Can you also lgtm? :) Not sure if there's anyone else around

@sbueringer
Copy link
Member Author

/hold
Have to check something

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@sbueringer sbueringer force-pushed the pr-finalize-diagnostics-addr branch from af09f7f to 492c01b Compare November 20, 2023 13:09
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2023
@sbueringer
Copy link
Member Author

Noticed a few other places where we didn't bump to v1.6.0-beta.1. Will run tests, verify metrics and then get back to you

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@sbueringer sbueringer changed the title 🌱 Finalize diagnostics implementation 🌱 Finalize CAPI v1.6.0-beta.1 bump & diagnostics implementation Nov 20, 2023
@sbueringer sbueringer force-pushed the pr-finalize-diagnostics-addr branch from 492c01b to a25337d Compare November 20, 2023 13:44
@sbueringer sbueringer force-pushed the pr-finalize-diagnostics-addr branch from a25337d to 16d552a Compare November 20, 2023 15:02
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@sbueringer
Copy link
Member Author

Okay we're now getting metrics from all controllers in the e2e artifacts

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@sbueringer
Copy link
Member Author

@chrischdi PTAL

chrischdi
chrischdi reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

@fabriziopandini @chrischdi Someone has to give me an lgtm :)

chrischdi
chrischdi reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dd3373f9ed1a133456c28c375a5765e7f93879a5

@k8s-ci-robot k8s-ci-robot merged commit b16f808 into kubernetes-sigs:main Nov 21, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 21, 2023
@sbueringer sbueringer deleted the pr-finalize-diagnostics-addr branch November 21, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@yastij yastij Awaiting requested review from yastij

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Bump to CR v0.16
4 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini