Skip to content

Commit

Permalink
disable ResourceVersionStable test
Browse files Browse the repository at this point in the history
  • Loading branch information
chrischdi committed Jun 20, 2024
1 parent 4629093 commit 42c5fc2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/e2e/cluster_upgrade_runtimesdk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"k8s.io/utils/ptr"
clusterctlcluster "sigs.k8s.io/cluster-api/cmd/clusterctl/client/cluster"
capi_e2e "sigs.k8s.io/cluster-api/test/e2e"
"sigs.k8s.io/cluster-api/test/framework"
)
Expand All @@ -45,7 +44,8 @@ var _ = Describe("When upgrading a workload cluster using ClusterClass with Runt
PostUpgrade: func(proxy framework.ClusterProxy, namespace, clusterName string) {

Check failure on line 44 in test/e2e/cluster_upgrade_runtimesdk_test.go

View workflow job for this annotation

GitHub Actions / lint (test)

unused-parameter: parameter 'proxy' seems to be unused, consider removing or renaming it as _ (revive)
// This check ensures that the resourceVersions are stable, i.e. it verifies there are no
// continuous reconciles when everything should be stable.
framework.ValidateResourceVersionStable(ctx, proxy, namespace, clusterctlcluster.FilterClusterObjectsWithNameFilter(clusterName))
// TODO(chrischdi): enable after https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/3059 merged
// framework.ValidateResourceVersionStable(ctx, proxy, namespace, clusterctlcluster.FilterClusterObjectsWithNameFilter(clusterName))
},
// "upgrades-runtimesdk" is the same as the "topology" flavor but with an additional RuntimeExtension.
Flavor: ptr.To(testSpecificSettingsGetter().FlavorForMode("topology-runtimesdk")),
Expand Down

0 comments on commit 42c5fc2

Please sign in to comment.