Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make private IP of the internal LB configurable #5315

Closed
wants to merge 1 commit into from
Closed

[WIP] Make private IP of the internal LB configurable #5315

wants to merge 1 commit into from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Nov 26, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • This PR is needed for updating Tilt workflow to spin up VM based templates with custom, non-overlapping Private IPs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5264

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

feat APIServerILB: private IP of the internal LB can be customized

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nawazkh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 26, 2024
@nawazkh nawazkh mentioned this pull request Dec 3, 2024
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@nawazkh nawazkh force-pushed the make_internal_lb_configurable branch from 9f43ff7 to 0f56695 Compare December 4, 2024 01:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@nawazkh nawazkh force-pushed the make_internal_lb_configurable branch from 0f56695 to d01d237 Compare December 4, 2024 01:37
@nawazkh nawazkh marked this pull request as ready for review December 4, 2024 01:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2024
@nawazkh nawazkh changed the title Make private IP of the internal LB configurable [WIP] Make private IP of the internal LB configurable Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.91525% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.60%. Comparing base (61c6f3f) to head (9f01586).

Files with missing lines Patch % Lines
api/v1beta1/azurecluster_default.go 83.33% 2 Missing and 1 partial ⚠️
api/v1beta1/azurecluster_validation.go 92.10% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5315      +/-   ##
==========================================
+ Coverage   52.51%   52.60%   +0.08%     
==========================================
  Files         272      272              
  Lines       29431    29488      +57     
==========================================
+ Hits        15457    15511      +54     
- Misses      13172    13174       +2     
- Partials      802      803       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh
Copy link
Member Author

nawazkh commented Dec 4, 2024

I am going to have an optional E2E using the new APIServerILB templates test this PR.
WIP hold is good for now.

@nawazkh nawazkh mentioned this pull request Dec 4, 2024
Closed
3 tasks
@nawazkh

This comment was marked as outdated.

Sign in to view
@nawazkh
Copy link
Member Author

nawazkh commented Dec 4, 2024

Will add e2e in this PR itself since the changes are tightly coupled.

@nawazkh nawazkh mentioned this pull request Dec 4, 2024
Merged
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Dec 4, 2024

Will add e2e in this PR itself since the changes are tightly coupled.

Created optional PR test for this feature gate changes via kubernetes/test-infra#33908

@nawazkh
Copy link
Member Author

nawazkh commented Dec 5, 2024

/test

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

8 similar comments
@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh nawazkh mentioned this pull request Dec 11, 2024
Merged
@nawazkh
Copy link
Member Author

nawazkh commented Dec 11, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

2 similar comments
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

A ray of hope: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5315/pull-cluster-api-provider-azure-apiserver-ilb/1866997818313412608

  STEP: Streaming stdout/err from the daemonset @ 12/12/24 00:40:47.131
  Captured output!!!!!!!!
  		Hello from node-debug pod

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

2 similar comments
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh nawazkh force-pushed the make_internal_lb_configurable branch 2 times, most recently from 265884f to b619fb5 Compare December 12, 2024 06:14
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

1 similar comment
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 12, 2024 •
edited
Loading

@nawazkh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-windows-with-ci-artifacts fe89d1e link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

1 similar comment
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
let users configure private IP of the internal LB
9f01586 
- update apiserver ilb flavor with custom CIDRs
- update apiserver ilb windows flavor with custom CIDRs
- create ci template for api server ILB PR tests

stub out e2e tests for apiserver ilb

- deploy apiserver ilb cluster in the e2e test
- update e2e test for apiserver ilb
@nawazkh nawazkh force-pushed the make_internal_lb_configurable branch from 9f1ba5a to 9f01586 Compare December 12, 2024 08:18
@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

/test pull-cluster-api-provider-azure-apiserver-ilb

@nawazkh
Copy link
Member Author

nawazkh commented Dec 12, 2024

Long list of conversation here, opened up a new PR to get the changes reviewed.
/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

Long list of conversation here, opened up a new PR to get the changes reviewed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Awaiting requested review from Jont828

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@mboersma mboersma Awaiting requested review from mboersma

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make internal LB IP configurable
2 participants
@nawazkh @k8s-ci-robot