WIP: [DO_NOT_MERGE] Change 2404 to 2204

[willie-yao]

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This PR is for running the upgrade test and figuring out issues found in #4575 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from willie-yao. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[willie-yao]

/test pull-cluster-api-provider-azure-apiversion-upgrade

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.79%. Comparing base (0957852) to head (d71321a).
Report is 34 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5228   +/-   ##
=======================================
  Coverage   52.78%   52.79%           
=======================================
  Files         270      270           
  Lines       29043    29043           
=======================================
+ Hits        15330    15332    +2     
+ Misses      12922    12920    -2     
  Partials      791      791           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

We haven't actually published 22.04 images, so this will 404. But I will do so now and we can see if this is the fix.

[mboersma]

/retest

[k8s-ci-robot]

@willie-yao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade	d71321a	link	true	/test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mboersma]

Even with Ubuntu 22.04, we're still spinning up new machines.

Does the upgrade test actually use an earlier version of CAPZ that still defaults to Marketplace images, then move to main where we default to the community gallery? Something like that would certainly cause a diff.

Maybe we should see if it's possible to skip this spec from the apiversion upgrade test. Or do we consider not rolling the machines on an upgrade to be core functionality here?

[willie-yao]

I think the CAPI test it considers any rollouts as a failure of upgrade so there's really no way around that. I guess we'll just have to disable the test in the meantime? Or is there a way to set the image of just this test to the Azure Marketplace image.

[mboersma]

/close

I think #5266 made this change not necessary any more. (@willie-yao please re-open if I'm wrong!)

[k8s-ci-robot]

@mboersma: Closed this PR.

In response to this:

/close

I think #5266 made this change not necessary any more. (@willie-yao please re-open if I'm wrong!)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.