Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle Entra auth for ASO API managed clusters #5211

Merged
merged 2 commits into from
Nov 16, 2024

handle Entra auth for ASO API managed clusters

dd9b8dc
Select commit
Loading
Failed to load commit list.
Merged

handle Entra auth for ASO API managed clusters #5211

handle Entra auth for ASO API managed clusters
dd9b8dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 16, 2024 in 0s

52.99% (+0.33%) compared to 976f893

View this Pull Request on Codecov

52.99% (+0.33%) compared to 976f893

Details

Codecov Report

Attention: Patch coverage is 65.60510% with 108 lines in your changes missing coverage. Please review.

Project coverage is 52.99%. Comparing base (976f893) to head (dd9b8dc).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
azure/credential_cache.go 15.78% 64 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go 57.14% 15 Missing and 6 partials ⚠️
controllers/aso_credential_cache.go 86.11% 15 Missing and 5 partials ⚠️
main.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5211      +/-   ##
==========================================
+ Coverage   52.66%   52.99%   +0.33%     
==========================================
  Files         273      272       -1     
  Lines       29189    29427     +238     
==========================================
+ Hits        15371    15596     +225     
+ Misses      13029    13027       -2     
- Partials      789      804      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov