fix(machinepool): clear VirtualMachineProfile if no model/custom data update #5164
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
|
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mweibel
force-pushed
the
fix-vmss-update-models
branch
from
06f39bd to
19d3251
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5164 +/- ##
==========================================
+ Coverage 51.35% 52.97% +1.62%
==========================================
Files 273 273
Lines 24671 29198 +4527
==========================================
+ Hits 12670 15469 +2799
- Misses 11212 12927 +1715
- Partials 789 802 +13 ☔ View full report in Codecov by Sentry. |
… update Scale up/down with MachinePool always updates the VM image model to use. This change sets the VirtualMachineProfile to nil when no change is necessary and ensures therefore less churn on scale up/downs leading to model updates which may require manual fixing Fixes some linting errors related to unnecessary params, too.
mweibel
force-pushed
the
fix-vmss-update-models
branch
from
19d3251 to
c8cf42a
Compare
|
/retest ^ looks like a flake |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 37ebd22eb8d86832791cd02014e08a101e29b9b4
|
|
/assign @nawazkh |
|
/test ls |
|
@nawazkh: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I will need some time understanding this change, I hope it is ok to hold for a day more. |
|
sure, take your time and let me know if there are questions. |
|
Sorry for the delay in responding on the PR. I was out of office for a day and the weekend before. |
same here, sorry for delaying the reply - I was on vacation last week. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.16 |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nojnhuh: new pull request created: #5203 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nojnhuh: new pull request created: #5204 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Scale up/down with MachinePool always updates the VM image model to use. This change sets the VirtualMachineProfile to nil when no change is necessary and ensures therefore less churn on scale up/downs leading to model updates which may require manual fixing
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4958
Special notes for your reviewer:
TODOs:
Release note: