remove special condition for workload id for conformance tests #5127
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
| @@ -203,34 +203,22 @@ function upload_to_blob() { | |||
| # to be mounted on the kind cluster and hence extra mount flags are required. | |||
| function createKindForAZWI() { | |||
| echo "creating workload-identity-enabled kind configuration" | |||
| if [ -n "${CONFORMANCE_FLAVOR}" ] && [ -n "${SERVICE_ACCOUNT_SIGNING_PUB}" ] && [ -n "${SERVICE_ACCOUNT_SIGNING_KEY}" ]; then | |||
There was a problem hiding this comment.
IIRC this condition in the kind script to use a different workload ID setup is a vestige of the pre-community infra and/or pre-workload ID default days and no longer is needed now.
@jackfrancis Does that sound right?
There was a problem hiding this comment.
That sounds plausible, conformance E2E test runs will tell us!
There was a problem hiding this comment.
Looks like the tests are all far enough along now that they've all created a cluster successfully, so I think we're in the clear.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5127 +/- ##
==========================================
- Coverage 51.25% 51.25% -0.01%
==========================================
Files 273 273
Lines 24651 24651
==========================================
- Hits 12636 12634 -2
- Misses 11229 11231 +2
Partials 786 786 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a914159eeebafd8c6ba5fa37d5e2e642efbe0295
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The new DRA periodic job sets
CONFORMANCE_FLAVORin order to use a DRA-enabled template and hits this error in the kind setup script:The other conformance jobs do not hit the same error because they leave
CONFORMACE_FLAVORundefined and let the e2e framework select a default flavor.IIRC this condition in the kind script to use a different workload ID setup is a vestige of the pre-community infra and/or pre-workload ID default days and no longer is needed now.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I don't see any other references to
CONFORMANCE_FLAVORin test-infra or any other repo, so I don't think this change should include any collateral damage.https://github.com/search?q=CONFORMANCE_FLAVOR+%28org%3Akubernetes+OR+org%3Akubernetes-sigs%29&type=code
TODOs:
Release note: