Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump resources on delete timeout #5120

Merged
merged 1 commit into from
Oct 8, 2024
Merged

dump resources on delete timeout #5120

merged 1 commit into from
Oct 8, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Sep 9, 2024 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR takes advantage of kubernetes-sigs/cluster-api#10961 new in CAPI 1.8 to dump resources when a delete operation times out like we've been seeing with AKS clusters recently.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (ffa6415) to head (eea97ee).
Report is 71 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5120      +/-   ##
==========================================
- Coverage   51.25%   51.25%   -0.01%     
==========================================
  Files         273      273              
  Lines       24651    24651              
==========================================
- Hits        12636    12634       -2     
- Misses      11229    11231       +2     
  Partials      786      786

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 10, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

2 similar comments
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2024

The most recent e2e test failure shows this is working as expected.

/retitle dump resources on delete timeout

@k8s-ci-robot k8s-ci-robot changed the title [WIP] dump resources on delete timeout dump resources on delete timeout Sep 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@nojnhuh nojnhuh mentioned this pull request Sep 19, 2024
Merged
4 tasks
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 23, 2024

/cherry-pick release-1.17

@k8s-infra-cherrypick-robot
Copy link

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor

/retest

1 similar comment
@mboersma
Copy link
Contributor

mboersma commented Oct 1, 2024

/retest

willie-yao
willie-yao approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53303a5ec01fe43ecdaa8f8dc9768a1a6ad1ef89

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@Jont828
Copy link
Contributor

Jont828 commented Oct 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a369783 into kubernetes-sigs:main Oct 8, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Oct 8, 2024
@k8s-infra-cherrypick-robot
Copy link

@nojnhuh: new pull request created: #5169

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 8, 2024
Merged
@nojnhuh nojnhuh deleted the delete-timeout-dump branch October 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@Jont828 Jont828

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@nojnhuh @k8s-infra-cherrypick-robot @mboersma @k8s-ci-robot @Jont828 @willie-yao