Change release job logic to handle more files #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4631 +/- ##
==========================================
- Coverage 62.73% 62.71% -0.02%
==========================================
Files 192 192
Lines 15641 15641
==========================================
- Hits 9812 9810 -2
- Misses 5146 5148 +2
Partials 683 683 ☔ View full report in Codecov by Sentry. |
Signed-off-by: David Tesar <[email protected]>
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1a3ea610b682d9164f123a82a5758794209143a5
|
|
/release-note-none |
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
removed
the
do-not-merge/release-note-label-needed
nojnhuh
reviewed
Mar 7, 2024
nojnhuh
reviewed
Mar 7, 2024
4 tasks
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/XS
Signed-off-by: David Tesar <[email protected]>
k8s-ci-robot
added
size/S
nojnhuh
reviewed
Mar 11, 2024
| if [[ ${{ steps.changed-files.outputs.all_changed_files_count }} != 1 ]]; then | ||
| echo "1 release notes file should be changed to create a release tag, found ${{ steps.changed-files.outputs.all_changed_files_count }}" | ||
| if [[ ${{ steps.changed-markdown-files.outputs.all_changed_files_count }} != 1 ]]; then | ||
| echo "1 release notes file should be changed to create a release tag, found ${{ steps.changed-markdown-files.outputs.all_changed_files_count }}" |
There was a problem hiding this comment.
After we get this PR merged, it looks like the changed-files action has a built-in way to feed the list of files into a matrix that can spawn one job per file which might be able to make cutting multiple patches pretty slick.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1728f38faec64d42a5ccbe58936ef708d5f92a7f
|
|
/hold for squash or until I can find the magic label to do it for us. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/label tide/merge-method-squash |
k8s-ci-robot
added
tide/merge-method-squash
k8s-ci-robot
removed
the
lgtm
|
There was a merge conflict with the newer version of the action, so had to push another commit. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 812d0c5b695ca9c47630b8c1a25050f251515727
|
mboersma
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 812d0c5b695ca9c47630b8c1a25050f251515727
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
bravebeaver
pushed a commit
to bravebeaver/cluster-api-provider-azure
that referenced
this pull request
Mar 19, 2024
* Change logic for only one file Signed-off-by: David Tesar <[email protected]> * Filter proper changed files Signed-off-by: David Tesar <[email protected]> * Fix logic Signed-off-by: David Tesar <[email protected]> --------- Signed-off-by: David Tesar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Makes it so there doesn't have to be two different sequential PRs to do a new release.