Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] eliminate short-circuiting in logic to add/remove finalizers #4222

eliminate short-circuiting in logic to add/remove finalizers

f47fd94
Select commit
Loading
Failed to load commit list.
Merged

[release-1.10] eliminate short-circuiting in logic to add/remove finalizers #4222

eliminate short-circuiting in logic to add/remove finalizers
f47fd94
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 2, 2023 in 0s

54.36% (+0.00%) compared to 47695c8

View this Pull Request on Codecov

54.36% (+0.00%) compared to 47695c8

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (47695c8) 54.36% compared to head (f47fd94) 54.36%.
Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10    #4222   +/-   ##
=============================================
  Coverage         54.36%   54.36%           
=============================================
  Files               186      186           
  Lines             18896    18898    +2     
=============================================
+ Hits              10272    10274    +2     
  Misses             8069     8069           
  Partials            555      555           
Files Coverage Δ
controllers/azuremanagedcontrolplane_controller.go 20.50% <0.00%> (-0.11%) ⬇️
controllers/helpers.go 56.15% <0.00%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.