Skip to content

Commit

Permalink
Skip name validation for AzureJSONMachine controller, revisited
Browse files Browse the repository at this point in the history
  • Loading branch information
mboersma committed Dec 2, 2024
1 parent ba6aa3d commit d5520b8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ func registerControllers(ctx context.Context, mgr manager.Manager) {
Timeouts: timeouts,
WatchFilterValue: watchFilterValue,
CredentialCache: credCache,
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachineConcurrency, SkipNameValidation: ptr.To(true)}); err != nil {
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachineConcurrency}); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "AzureJSONTemplate")
os.Exit(1)
}
Expand All @@ -420,7 +420,7 @@ func registerControllers(ctx context.Context, mgr manager.Manager) {
Timeouts: timeouts,
WatchFilterValue: watchFilterValue,
CredentialCache: credCache,
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachineConcurrency}); err != nil {
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachineConcurrency, SkipNameValidation: ptr.To(true)}); err != nil {

Check warning on line 423 in main.go

View check run for this annotation

Codecov / codecov/patch

main.go#L423

Added line #L423 was not covered by tests
setupLog.Error(err, "unable to create controller", "controller", "AzureJSONMachine")
os.Exit(1)
}
Expand Down Expand Up @@ -478,7 +478,7 @@ func registerControllers(ctx context.Context, mgr manager.Manager) {
Timeouts: timeouts,
WatchFilterValue: watchFilterValue,
CredentialCache: credCache,
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachinePoolConcurrency}); err != nil {
}).SetupWithManager(ctx, mgr, controller.Options{MaxConcurrentReconciles: azureMachinePoolConcurrency, SkipNameValidation: ptr.To(true)}); err != nil {

Check warning on line 481 in main.go

View check run for this annotation

Codecov / codecov/patch

main.go#L481

Added line #L481 was not covered by tests
setupLog.Error(err, "unable to create controller", "controller", "AzureJSONMachinePool")
os.Exit(1)
}
Expand Down

0 comments on commit d5520b8

Please sign in to comment.