-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Clarify that the ROSA provider is currently for ROSA HCP clusters #5268
base: main
Are you sure you want to change the base?
Conversation
/assign mzazrivec serngawy Just as an fyi! |
@mjlshen: GitHub didn't allow me to assign the following users: mzazrivec. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Michael Shen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @serngawy - I tried to take a more thorough pass through all the cluster-api-provider-aws/controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Line 137 in 07a93a5
|
Thanks @mjlshen , the main focus is the md files but if you find places in CRDs that also can be fixed to ROSA-HCP that will be helpful. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The more explicit product name is ROSA HCP, see issue for more details
Which issue(s) this PR fixes:
Fixes #5257
Checklist:
Release note: