🐛 Downgrade kustomize and prevent dependabot bumps #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kustomize previously broke builds (kubernetes-sigs#5188) and we mistakenly approved a version bump (kubernetes-sigs#5232) that caused the Go version to be >= 1.22.7. As of right now, the builder image only has Go 1.22.0. This change downgrades the relevant kustomize dependencies, as well as prevents dependabot from incrementing kustomize automatically in the future. Signed-off-by: Nolan Brubaker <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
Thank you! /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
To avoid issues like this in the future I really think we should run pull-cluster-api-provider-aws-e2e by default on PRs(presubmits), and maybe have it non optional. It would catch all of these regressions. |
2 tasks
|
^ Folks what do you think of the above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind regression
What this PR does / why we need it:
Kustomize previously broke builds
(#5188)
and we mistakenly approved a version bump
(#5232)
that caused the Go version to be >= 1.22.7. As of right now, the builder
image only has Go 1.22.0.
This change downgrades the relevant kustomize dependencies, as well as
prevents dependabot from incrementing kustomize automatically in the
future.
Checklist:
Release note: